fix: use nvim-treesitter define_modules to attach/detach to buffers #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dane-harnett
commented
Jan 9, 2023
| @@ -140,34 +140,15 @@ nvim_biscuits.decorate_nodes = function(bufnr, lang) | |||
| end | |||
| end | |||
|
|
|||
| nvim_biscuits.setup = function(user_config) | |||
There was a problem hiding this comment.
I moved this function below nvim_biscuits.BufferAttach definition so that we can use it inside the setup.
dane-harnett
commented
Jan 9, 2023
| local attached_buffers = {} | ||
| nvim_biscuits.BufferAttach = function(bufnr) | ||
| bufnr = bufnr or vim.api.nvim_get_current_buf() |
There was a problem hiding this comment.
The bufnr should now be passed in.
dane-harnett
commented
Jan 9, 2023
| if attached_buffers[bufnr] then return end | ||
|
|
||
| attached_buffers[bufnr] = true | ||
|
|
||
| local lang = ts_parsers.get_buf_lang(bufnr):gsub("-", "") |
There was a problem hiding this comment.
The lang should now be passed in.
dane-harnett
commented
Jan 9, 2023
| local toggle_keybind = config.get_language_config(final_config, lang, | ||
| "toggle_keybind") | ||
| if toggle_keybind ~= nil and | ||
| not config.get_language_config(final_config, lang, "disabled") then |
There was a problem hiding this comment.
This is now implemented in the is_supported function below
dane-harnett
commented
Jan 9, 2023
| @@ -2,7 +2,3 @@ | |||
|
|
|||
| highlight default BiscuitColor ctermfg=gray guifg=gray | |||
|
|
|||
| augroup NVIM_BISCUITS | |||
There was a problem hiding this comment.
We no longer need this.
|
Awesome. This looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
By changing the way nvim-biscuits attaches to the buffer (using the nvim-treesitter define_modules functionality)
it seems to have resolved the issue I was experiencing when opening a file via telescope.
I suspect that the BufEnter autocmd was triggering too early causing the buffer to not complete have been registered with treesitter and so the language was empty string.